move the shared dynamic libs to lib#70
Merged
codie3611 merged 1 commit intoopen-lasso-python:developfrom Apr 8, 2025
saudzahirr:refactor/move_compiled_dynamic_obj_to_lib
Merged
move the shared dynamic libs to lib#70codie3611 merged 1 commit intoopen-lasso-python:developfrom saudzahirr:refactor/move_compiled_dynamic_obj_to_lib
lib#70codie3611 merged 1 commit intoopen-lasso-python:developfrom
saudzahirr:refactor/move_compiled_dynamic_obj_to_lib
Conversation
Contributor
saudzahirr
commented
Apr 8, 2025
- refactor femzip_api to accomodate changes
- update .gitignore to keep dll/so files
* refactor femzip_api to accomodate changes * update .gitignore to keep dll/so files
Contributor
|
What was the reason to move it? Clean up or a bug? |
Contributor
Author
It is basically a cleanup and will help further optimize the femzip API code. I am working on the femzip API and will improve the code logic. This PR is one of those to come. |
codie3611
approved these changes
Apr 8, 2025
Contributor
Author
|
@codie3611 I don’t have merge rights—could you help with this when you can! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.